Skip to content

btcli: update test #246932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

btcli: update test #246932

wants to merge 2 commits into from

Conversation

@chenrui333
Copy link
Member

@chenrui333 chenrui333 commented Oct 5, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

seeing test failure in https://github.com/Homebrew/homebrew-core/actions/runs/18254145963/job/51978790297?pr=246920#step:3:690

relates to #246920

@chenrui333
btcli: update test
b6a18f5 
Signed-off-by: Rui Chen <[email protected]>
@chenrui333 chenrui333 added the CI-no-bottles Merge without publishing bottles label Oct 5, 2025
@github-actions github-actions bot added python Python use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue and removed CI-no-bottles Merge without publishing bottles labels Oct 5, 2025
@chenrui333 chenrui333 added the CI-no-bottles Merge without publishing bottles label Oct 5, 2025
@daeho-ro
Copy link
Member

daeho-ro commented Oct 5, 2025

Isn't that a new wallet? How there is a balance?

@chenrui333
Copy link
Member Author

chenrui333 commented Oct 5, 2025

Isn't that a new wallet? How there is a balance?

it is a new wallet and now it is 4.0e-05 rather than 0.0

@chenrui333 chenrui333 mentioned this pull request Oct 5, 2025
Closed
@chenrui333 chenrui333 added the upstream issue An upstream issue report is needed label Oct 5, 2025
@thewhaleking
Copy link
Contributor

thewhaleking commented Oct 7, 2025

Looking at this.

@thewhaleking
Copy link
Contributor

thewhaleking commented Oct 7, 2025

Should now be resolved with the original test case.

@chenrui333
Revert "btcli: update test"
ad164aa 
This reverts commit b6a18f5.
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Oct 8, 2025
@chenrui333
Copy link
Member Author

chenrui333 commented Oct 8, 2025

Thanks @thewhaleking, gonna regression test now.

@chenrui333 chenrui333 marked this pull request as draft October 8, 2025 00:03
@chenrui333
Copy link
Member Author

chenrui333 commented Oct 9, 2025

looks good, closing. thanks again!

@chenrui333 chenrui333 closed this Oct 9, 2025
@github-actions github-actions bot deleted the btcli-test branch October 9, 2025 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

autosquash Automatically squash pull request commits according to Homebrew style. CI-no-bottles Merge without publishing bottles python Python use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue upstream issue An upstream issue report is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chenrui333 @daeho-ro @thewhaleking